I'm playing around with a fork of mainnet on a local chain and using UniswapV3 to test some swap functionality. When using the OracleLibrary to get prices via consult(), I've found it tricky when using a lesser known token with only one observation stored. Each time a swap occurs the one observation is then overwritten with the timestamp of when this happened. This means when running a consult soon after, the secondsAgo needs to be no more than the last timestamp for the latest swap otherwise running into this revert: https://github.com/Uniswap/v3-core/blob/main/contracts/libraries/Oracle.sol#L226
At the moment I check getOldestObservationSecondsAgo() > secondsAgo before calling, and if not I need to call slot0() on the pool directly and grab the latest tick. I feel like this could be handled within the OracleLibrary a little better though, perhaps consult could implement this itself but I'm open to other ideas.
I also considered using getBlockStartingTickAndLiquidity in the OracleLibrary but there's a check here ( https://github.com/Uniswap/v3-periphery/blob/main/contracts/libraries/OracleLibrary.sol#L97 ) that there's at least 2 observations. However the next block simply returns the pools slot0() observation anyway... regardless of the above, it feels like the require should move below this block anyway?
Happy to look at PRs if helpful. Just getting thoughts on this first as I assume you folks know the code far better than me.
Hey there,
I'm playing around with a fork of mainnet on a local chain and using UniswapV3 to test some swap functionality. When using the OracleLibrary to get prices via consult(), I've found it tricky when using a lesser known token with only one observation stored. Each time a swap occurs the one observation is then overwritten with the timestamp of when this happened. This means when running a consult soon after, the
secondsAgoneeds to be no more than the last timestamp for the latest swap otherwise running into this revert: https://github.com/Uniswap/v3-core/blob/main/contracts/libraries/Oracle.sol#L226At the moment I check
getOldestObservationSecondsAgo() > secondsAgobefore calling, and if not I need to call slot0() on the pool directly and grab the latest tick. I feel like this could be handled within the OracleLibrary a little better though, perhapsconsultcould implement this itself but I'm open to other ideas.I also considered using
getBlockStartingTickAndLiquidityin the OracleLibrary but there's a check here ( https://github.com/Uniswap/v3-periphery/blob/main/contracts/libraries/OracleLibrary.sol#L97 ) that there's at least 2 observations. However the next block simply returns the pools slot0() observation anyway... regardless of the above, it feels like the require should move below this block anyway?Happy to look at PRs if helpful. Just getting thoughts on this first as I assume you folks know the code far better than me.