search

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.16k stars 1.08k forks source link

fix compilation error with solc > 0.8, fixes #177 #271

Closed ChrisiPK closed 1 year ago

ChrisiPK commented 2 years ago

Fixes the compilation error in PoolLibrary with Solidity 0.8. Now, we first cast to uin160 before casting to address.

willpote commented 2 years ago

Thanks for this change, could you move this to a separate branch called '0.8', similar to what we did for v3-core here?

ChrisiPK commented 2 years ago

I will try to update all the contracts to 0.8 and create a second PR for this.

However, I disagree that this change should not be incorporated into the 0.7 version. It doesn't break compatibility with older versions and enables users to include the PoolAddress contract in their 0.8 projects already. The solidity version pragma of this file doesn't exclude compatibility with 0.8 so it should be fixed to work with 0.8.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

ChrisiPK commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Still relevant IMHO. Would be happy to hear from maintainers what is blocking it from their perspective.

therealdannzor commented 2 years ago

Curious to know too 😄

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

still relevant

jmfrancolin commented 1 year ago

still relevant

A-ndy-git commented 1 year ago

+1

ethanolle commented 1 year ago

+1

andreujuanc commented 1 year ago

Can anyone check if the truncation is done right? and behaves according to < v8?

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

still relevant

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

ChrisiPK commented 1 year ago

Still relevant. I would also like to know if there is anything blocking it and if there is something we can do to move it forward.

@andreujuanc How do you suggest to test this?

andreujuanc commented 1 year ago

@ChrisiPK Sadly I don't remember why I was checking this PR :D

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

passabilities commented 11 months ago

any updates?

kryptoklob commented 11 months ago

still relevant

arr00 commented 5 months ago

This should be merged @hensha256