search

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.16k stars 1.08k forks source link

🐛 use solidity version range for interfaces and libraries #288

Closed cruzdanilo closed 7 months ago

cruzdanilo commented 2 years ago

this allows apps and integrators to use this project as a library, especially CallbackValidation.

hensha256 commented 2 years ago

Hi @cruzdanilo! I have allowed this PR to have our workflows run on it so we can look at getting it merged for you. Sadly the workflows have failed - please can you take a look at the failures! Once they pass we can review it for merging.

cruzdanilo commented 2 years ago

@hensha256 thank you. the error seems to be about a github integration failure. can you please retry/re-run the github action?

Verifying setup for Prettier…
Verified Prettier setup
Will use Prettier to check the files with extensions css,html,js,json,jsx,md,sass,scss,ts,tsx,vue,yaml,yml,sol
Linting and auto-fixing files in /home/runner/work/v3-periphery/v3-periphery with Prettier…
Prettier found no issues (success)
No changes found with Git

SHA of last commit is "3f4f2c08[55](https://github.com/Uniswap/v3-periphery/runs/7785217331?check_suite_focus=true#step:5:56)cd690f68387dd478c31a0a07bade12"
Creating GitHub check with 0 annotations for Prettier…
Error: Received status code 403
hensha256 commented 2 years ago

ah its because this is a fork not a branch - let me see if we can give prettier permissions to run on forks

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

this is still relevant.

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

this is still relevant.

Seesaem commented 1 year ago

@hensha256 did you manage to give permissions to prettier?

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

this is still relevant.

Dayo-Adewuyi commented 1 year ago

we need this to be merged. the pain the current flow is causing is unwarranted

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 1 year ago

this is still relevant.

stale[bot] commented 12 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 12 months ago

this is still relevant.

stale[bot] commented 9 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 9 months ago

this is still relevant.

stale[bot] commented 7 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cruzdanilo commented 7 months ago

this is still relevant.