Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.16k stars 1.08k forks source link

1.4.2 version is not compatible with v3-sdk #313

Closed ChaituVR closed 1 year ago

ChaituVR commented 1 year ago
Error: Cannot find module '@uniswap/v3-periphery/artifacts/contracts/interfaces/IMulticall.sol/IMulticall.json'
[2022-09-19 18:35:23] Require stack:
[2022-09-19 18:35:23] - /workspace/node_modules/@uniswap/v3-sdk/dist/v3-sdk.cjs.development.js
[2022-09-19 18:35:23] - /workspace/node_modules/@uniswap/v3-sdk/dist/index.js

This happens when we tried to update 1.4.1 version to 1.4.2 version

muhammadsamir11 commented 1 year ago

Did you find a solution?

jakubdonovan commented 1 year ago

Did you find a solution?

I would also like to know. The artifacts folder is not there.

ChaituVR commented 1 year ago

Tried different ways but ended up using yarn resolutions to use 1.4.1 version, hope they fix it in next version update

jdubpark commented 1 year ago

artifacts folder is missing in 1.4.2 for some reason, for now the solution is downgrading to 1.4.1 to continue using the artifacts.

FYI, this works for me:

{
    "@uniswap/sdk": "^3.0.3",
    "@uniswap/sdk-core": "^3.0.1",
    "@uniswap/smart-order-router": "^2.9.2",
    "@uniswap/v3-core": "^1.0.1",
    "@uniswap/v3-periphery": "^1.4.1",
    "@uniswap/v3-sdk": "^3.9.0",
}

command: npm i @uniswap/v3-periphery@1.4.1

bigchiano commented 1 year ago

artifacts folder is missing in 1.4.2 for some reason, for now the solution is downgrading to 1.4.1 to continue using the artifacts.

FYI, this works for me:

{
    "@uniswap/sdk": "^3.0.3",
    "@uniswap/sdk-core": "^3.0.1",
    "@uniswap/smart-order-router": "^2.9.2",
    "@uniswap/v3-core": "^1.0.1",
    "@uniswap/v3-periphery": "^1.4.1",
    "@uniswap/v3-sdk": "^3.9.0",
}

command: npm i @uniswap/v3-periphery@1.4.1

Thank you, this solved the issue for me.

dade-ca commented 1 year ago

This workaround worked for me:

  "resolutions": {
    "@uniswap/v3-periphery": "1.4.1"
  }

in package.json

roigecode commented 1 year ago

This also worked for me!

"dependencies": {
    "@uniswap/v3-periphery": "1.4.1",
  }
hensha256 commented 1 year ago

fixed in 1.4.3, sorry this took so long...