Release tag and npm version out of sync

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3

https://uniswap.org

GNU General Public License v2.0

1.16k stars 1.08k forks source link

Open QYuQianchen opened 1 year ago

QYuQianchen commented 1 year ago

NPM package is release at version v1.4.3 https://www.npmjs.com/package/@uniswap/v3-periphery, while the release tag on Github is only v1.3.0.

Keeping them in sync ensures that the same code gets imported in hardhat (via npm) and in foundry (via Github)

Add a github action that releases to npm automatically on tag push (props to @delaaxe for the idea)

drLis commented 1 year ago

Agree. Please update tags for solidity 0.8 branchs, because all we need it for correct working of brownie pm manager (can works only with tag)

startswithaj commented 1 year ago

Is there a plan to release 1.4.2-solc-0.8 version to NPM?

startswithaj commented 1 year ago

v3-core has a solc 8 version released: