search

Uniswap / v3-sdk

🛠 An SDK for building applications on top of Uniswap V3
MIT License
547 stars 425 forks source link

JSBI values are compared incorrectly #115

Closed dalechyn closed 2 years ago

dalechyn commented 2 years ago

Hello. https://github.com/Uniswap/v3-sdk/blob/545fb4eb9003cd20c185fdd62949008695283012/src/entities/pool.ts#L290 Here two JSBI numbers are compared with type coercing, I think they should be compared just as few lines above with help of JSBI.notEqual.

marktoda commented 2 years ago

Great catch, thanks for reporting this!

marktoda commented 2 years ago

Fixed here https://github.com/Uniswap/v3-sdk/pull/130