Updated comparison function

Uniswap / v3-sdk

🛠 An SDK for building applications on top of Uniswap V3

MIT License

547 stars 425 forks source link

Closed sidneyschwartz closed 2 years ago

sidneyschwartz commented 2 years ago

Changed from comparison using != to JSBI.notEqual function in 'pool.ts'. This removes any vulnerabilities of miscomparisons. Resolved Issue #115

moodysalem commented 2 years ago

would love a unit test, otherwise we can write one

marktoda commented 2 years ago

Linter appears to be failing @sidneyschwartz

marktoda commented 2 years ago

Merging in here https://github.com/Uniswap/v3-sdk/pull/130 @sidneyschwartz -- thanks!