Closed Jesse-Sawa closed 2 years ago
There's a lot of argument duplication here that makes the diff bigger than it needs to be. It looks like the only real differences in implementation are the argument wrapper and the string function names. Can you make the boolean logic handle only those decisions instead of wrapping duplicate argument constructions as well?
Can you also add some tests here that demonstrate usage of the new quoter option?
The Uniswap/deploy-v3 (what we used for Celo) deploys the V2 Quoter. Here is the IQuoterV2 interface to see the corresponding structs associated with these changes.