search

Uniswap / v3-sdk

🛠 An SDK for building applications on top of Uniswap V3
MIT License
544 stars 416 forks source link

Wrong minimumAmountOut calculation #147

Closed hieuvo closed 1 year ago

hieuvo commented 1 year ago

https://github.com/Uniswap/v2-sdk/blob/main/src/entities/trade.ts#L186 https://github.com/Uniswap/v3-sdk/blob/main/src/entities/trade.ts#L438

In both v2 and v3 sdk, the formula to calculate minimumAmountOut is minimumAmountOut = amountOut / (1 + slippage)

But I believe it should be minimumAmountOut = amountOut * (1 - slippage)

usgeeus commented 11 months ago

which one is correct? can you please explain about it @hieuvo