Uniswap / v3-subgraph

Subgraph for Uniswap V3
GNU General Public License v3.0
326 stars 458 forks source link

collectedFeesTokenx is incorrect or 0 since position 138293 #82

Open archerabi opened 2 years ago

archerabi commented 2 years ago

There isn't any documentation on this, but i'm assuming the collectedFeesTokenX = withdrawnTokenX + tokenXFees

It looks like since position id 138293, the collectedFeesToken is either 0 or a completely wrong value.

{
  positions(orderDirection:asc, first: 100, where:{ id_gt: 138200, liquidity: 0}){
    id
    liquidity
    withdrawnToken0
    withdrawnToken1
    depositedToken0
    depositedToken1
    collectedFeesToken0
    collectedFeesToken1
    owner
    token0{
      symbol
  }
    token1{
      symbol
    }
    transaction{
      id
    }
  }
}
archerabi commented 2 years ago

Could it be related to this PR https://github.com/Uniswap/v3-subgraph/pull/76 @ianlapham

Specifically this diff https://github.com/Uniswap/v3-subgraph/commit/ff07a11ec5aa9112585f72ff052c3b2fce87c14c#diff-0ed4aab3f572ceed243d5ac0c47f94469388964b541aa4c4a97ff5f3b56ec33aL163

SnakeMM commented 2 years ago

I met this problem, too. So it is still not solved for six months? The position id is larger than 230000 now...

atr0t0s commented 1 year ago

This is still unsolved a year later...

tkeidar commented 1 year ago

any update on this issue? is there any WA to get the collected fees? I see that even under positionSnapshots it doesn't return the collect transactions

atr0t0s commented 1 year ago

There’s an alternative way to do it. Check the Revert finance uni v3 subgraph, theirs gets the collected fees and I’ve been using their method.

On 20 Dec 2022, at 12:58 PM, Tom Keidar @.***> wrote:

any update on this issue? is there any WA to get the collected fees? I see that even under positionSnapshots it doesn't return the collect transactions

— Reply to this email directly, view it on GitHub https://github.com/Uniswap/v3-subgraph/issues/82#issuecomment-1359180457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZDY2TNYHRLLVEO53QAS3WOGGOJANCNFSM5JVNR5FA. You are receiving this because you commented.

Arsalan-Habib commented 1 month ago

Almost 3 years, still no fix, unfortunately. @atr0t0s can you please share the revert subgraph, can't seem to find it.