Rename liquidityDelta in IPoolManager.ModifyPositionParams

Uniswap / v4-core

🦄 🦄 🦄 🦄 Core smart contracts of Uniswap v4

https://blog.uniswap.org/uniswap-v4

Other

1.96k stars 929 forks source link

Rename liquidityDelta in IPoolManager.ModifyPositionParams #746

Open snreynolds opened 3 months ago

snreynolds commented 3 months ago

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

I think the term "delta" should be conventionally used to describe credits or debits in token0 or token1 owed to or from the pool manager.

not sure of a better name tho... just liquidity?

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

linear[bot] commented 3 months ago

PROTO-282 Rename liquidityDelta in IPoolManager.ModifyPositionParams

wjmelements commented 2 months ago

liquidityDelta is a fine name for the liquidity delta. Delta is a good term for any signed integer exclusively used for addition.

tom2o17 commented 2 months ago

I like Delta given it refers to the change in liquidity for the position being modified.

snreynolds commented 3 weeks ago

I think that I had wanted to change callerDelta -> liquidityDelta in the return variables to match swap's swapDelta which means I dont want it to be overloaded with the params

snreynolds commented 3 weeks ago