Uniswap / v4-core

🦄 🦄 🦄 🦄 Core smart contracts of Uniswap v4
https://blog.uniswap.org/uniswap-v4
Other
1.94k stars 918 forks source link

consistency in mask constants #797

Open snreynolds opened 1 month ago

snreynolds commented 1 month ago

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

In many places we use uint160/uint24 masks. In slot0.sol we define them as constants, but everywhere else we just inline them. I think we should just make it consistent wherever we are masking

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

linear[bot] commented 1 month ago

PROTO-322 consistency in mask constants