search

Uniswap / v4-core

🦄 🦄 🦄 🦄 Core smart contracts of Uniswap v4
https://blog.uniswap.org/uniswap-v4
Other
1.93k stars 914 forks source link

[Bug]: Consider removing the preemptive revert before calling the protocolFeeController #814

Closed snreynolds closed 1 week ago

snreynolds commented 1 month ago

Describe the bug

we check if there is enough gasleft before calling the protocolFeeController, I think this is an unnecessary check

Expected Behavior

no gasleft check

To Reproduce

No response

Additional context

No response

linear[bot] commented 1 month ago

PROTO-391 [Bug]: Consider removing the preemptive revert before calling the protocolFeeController

snreynolds commented 1 week ago

Closing. Without this check, a caller could send just under the gasLimit to cause the external call to not succeed (bypassing it) while still continuing the rest of the function logic