search

Uniswap / v4-core

🦄 🦄 🦄 🦄 Core smart contracts of Uniswap v4
https://blog.uniswap.org/uniswap-v4
Other
1.99k stars 950 forks source link

Bubble up revert from unlockCallback #816

Closed snreynolds closed 1 month ago

snreynolds commented 2 months ago

Component

Lock and Call

Describe the suggested feature and problem it solves.

this would make bubble up reverts more consistent wth the property that bubble ups should happen on external contract calls

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

linear[bot] commented 2 months ago

PROTO-396 Bubble up revert from unlockCallback

snreynolds commented 1 month ago

After some discussion, have decided that there is not much benefit to bubbling up a revert where the caller is the msg.sender