search

Uniswap / v4-periphery

🦄 🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v4
https://blog.uniswap.org/uniswap-v4
GNU General Public License v2.0
688 stars 464 forks source link

Allow integrators to override `PositionManager.transferFrom` #278

Closed brockmiller closed 1 month ago

brockmiller commented 1 month ago

Related Issue

Which issue does this pull request resolve?

Description of changes

This PR makes the PositionManager.transferFrom method virtual so that integrators who are extending PositionManger can override its functionality more easily.

saucepoint commented 1 month ago

thanks for the PR! can you make sure your commit is signed (appears as verified)

assuming you've registered your signing key (recommend doing it with SSH key) you should be able to retroactively do it on the branch with

git rebase --exec 'git commit --amend --no-edit -n -S' -i origin/HEAD