Closed naddison36 closed 4 days ago
Here's some example tx2uml call diagrams using Uniswap v4 hooks with parameter names https://github.com/naddison36/uniswap-v4-hooks/tree/main/docs#modify-liquidity
hey sorry for the slow response
the solidity compiler will throw warnings when variables are unused, so going to close this issue for now
Component
Pool Interaction, Hooks
Describe the suggested feature and problem it solves.
Please add the parameter names to the hook functions in the
BaseHook
contract.Yes, the Solidity compiler will spit out warnings that these parameters are not used, but the purpose of
BaseHook
is to allow developers to extend it. Knowing what the parameters are without having to look at theIHook
interface is very useful.Describe the desired implementation.
Instead of
Add the parameter names
Describe alternatives.
N/A
Additional context.
Contract and tx visualisation tools like sol2uml and tx2uml can also use the parameter names