Uniswap / web3-react

A simple, maximally extensible, dependency minimized framework for building modern Ethereum dApps
https://web3-react-mu.vercel.app/
GNU General Public License v3.0
5.54k stars 1.52k forks source link

Adding Keystone hardware wallet to web3-react #229

Closed BitcoinLixin closed 2 years ago

BitcoinLixin commented 3 years ago

Hi! web3-react is amazing!

We are Keystone hardware wallet team. We have been in the space for over 3 years (with previous brand Cobo Vault). We were mostly working on Bitcoin security and recently we started to explore what we can help in Ethereum community. This is a quick demo we have just released last week.

Aside from ABI decoding to avoid some classic attacks like phishing sites, we have some other advantages compared to current hardware solution for Ethereum:

Question - What's the process of getting integrated with web3-react (we will submit PR but do we need to send sample device to anyone for testing before get merged)? If sample device is needed, who should I ping?

Thanks!

NoahZinsmeister commented 2 years ago

hi! thanks for the interest, please see https://github.com/NoahZinsmeister/web3-react/#adding-connectors for guidance on adding connectors