Uniswap / widgets

widgets-uniswap.vercel.app
GNU General Public License v3.0
125 stars 180 forks source link

Gray strip overlaps header in the token list #584

Open cawabunga opened 1 year ago

cawabunga commented 1 year ago

Bug Description Grayish strip overlaps header in the list of tokens, which disallows to close the list.

Steps to Reproduce

  1. Click on token select
  2. List is opened with grayish strip in the header

Expected Behavior I am not sure the purpose of the strip, but I suppose it should be placed on element of the active token.

Additional Context Codesandbox

Screenshot

Screenshot 2023-05-11 at 18 30 00

justinevedovato commented 1 year ago

I'm having the same issue, I have a list of several tokens, and when I hover on them, the gray strip moves along. Hovering the 1st element will hide the closing button, hovering on the 2nd one hides the input field, and so on.

Not sure what's causing it, nothing's been changed in the style, except for the dark mode. But it happens also in light mode, just like the screenshot above.

Screenshots ![brave_NWxCFHorBX](https://github.com/Uniswap/widgets/assets/64984802/eb5d21b9-3411-4284-90ff-ffd2752e4e45) ![brave_bEFjLVzVBc](https://github.com/Uniswap/widgets/assets/64984802/e7463af5-3330-458f-9cfb-cf3e768688a0) ![brave_8KQkwB8bp4](https://github.com/Uniswap/widgets/assets/64984802/7856ff27-4da8-4136-aa0e-79973b93cd30)
datnguyen-tech commented 1 year ago

Has anyone been able to fix that? I'm having the same issue :((

cawabunga commented 1 year ago

Has anyone been able to fix that? I'm having the same issue :((

I had to do a quick fix. Wrap your uniswap widget with <div class="uniswap"> and add next css:

.uniswap [color='container'] > div > div:nth-child(3) {
  position: relative;
}
justinevedovato commented 1 year ago

Thanks for the fix!

TrejGun commented 1 year ago

same here

beautyfree commented 11 months ago

Same issue

looks like the reason is in this package https://github.com/Uniswap/widgets/blob/main/src/components/TokenSelect/TokenOptions.tsx#L229