Closed abarthell closed 10 months ago
@abarthell is attempting to deploy a commit to the Uniswap Team on Vercel.
A member of the Team first needs to authorize it.
@abarthell assuming you were able to test locally, get quotes and execute trades - please mark this PR ready for review when you want us to review it !
@abarthell assuming you were able to test locally, get quotes and execute trades - please mark this PR ready for review when you want us to review it !
@just-toby I don't think this PR will work until USDC on Base is added here (instead of USDbC). Should I also make a change there first? I wasn't sure if it'd cause some issue with the existing pool to just swap the contract address
@abarthell that's a token constant in our interface
repo - it doesn't affect the widget. feel free to send us a PR to update it, but i don't think it's related to this PR.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
widgets | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 22, 2023 0:30am |
@abarthell please run yarn deduplicate
- i'm seeing the lints and tests passing locally, so i don't think we need to worry about those checks. probably just need to rerun or fix the github action
@abarthell please run
yarn deduplicate
- i'm seeing the lints and tests passing locally, so i don't think we need to worry about those checks. probably just need to rerun or fix the github action
@just-toby Sounds good! just ran deduplicate and also bumped the deps it was erroring on
the test suite is only failing in your fork because you don't have the JSON_RPC_PROVIDER
env variable set. it's passing for me and it should pass on main
once we merge
edit: i forgot the check is required. so we don't break protocol here, do you mind setting the env variable so we can re-run the tests and get all green ? :D
the test suite is only failing in your fork because you don't have the
JSON_RPC_PROVIDER
env variable set. it's passing for me and it should pass onmain
once we mergeedit: i forgot the check is required. so we don't break protocol here, do you mind setting the env variable so we can re-run the tests and get all green ?
@just-toby Ahh I see, good catch. I just set JSON_RPC_PROVIDER = https://mainnet.infura.io
in the github fork env vars. can we try re-running it?
hmm @abarthell i think i was wrong and it's our repo that has the wrong value for this variable. i'll get it updated and make sure your PR gets merged. (might be tomorrow since i don't have permissions to edit the settings in this repo)
@just-toby Can we try re-running it one more time? I think I had the wrong variable before actually
@just-toby can you help upgrade the latest npm version of the widget as well? 😁
Also, here's two more PRs to add Base USDC on the interface (instead of USDbC) and the corresponding assets:
Add Base support to Uniswap widget.
Tested swapping ETH to USDC on Base: https://basescan.org/tx/0xb230b5039555c3087b61906555b1b9495395cb60486b68f9871f791505429789