search

Uniswap / widgets

widgets-uniswap.vercel.app
GNU General Public License v3.0
123 stars 175 forks source link

usepermit should return not_applicable if wallet doesnt support signtypeddata_v4 #624

Open sirpy opened 9 months ago

sirpy commented 9 months ago

For wallet connect it is possible to check the returned supported methods, maybe it is possible to verify for other wallets in some other way https://github.com/Uniswap/widgets/blob/e66edb659a299bdee046afd3e49b294b8948e642/src/hooks/usePermit.ts#L138

maybe also allow the dev embedding the widget to force usage of approve

sirpy commented 2 days ago

anyone?

sirpy commented 2 days ago

with a wallet that doesnt support it, swapping works fine on app.uniswap.org but doesnt work with the widget