Open Khez opened 3 years ago
ping @Unitech
Is there any further information about this, or is this considered a dead proposal?
We've also noticed this in our log files. It's especially annoying because we use JSON log types and when these rejections come through, the output is not valid JSON.
@Unitech do you have any input on this?
What's going wrong?
Error stream is polluted with an intrusive log that can't be turned off or customised.
PM2 in cluster mode does
logError(error)
in https://github.com/Unitech/pm2/blob/4.5.0/lib/ProcessContainer.js#L258 PM2 in fork mode with module@pm2/io
doesconsole.error(error)
in https://github.com/keymetrics/pm2-io-apm/blob/4.3.5/src/features/notify.ts#L166This happens even if a custom uncaughtException or unhandledRejection is added through the app.
How could we reproduce this issue?
Create an app.js file:
Running this through
node app.js
outputs on console.error our custom JSON error message:Running this through
pm2 start app.js
(fork mode) breaks our JSON error message:Running this through
pm2 start app.js -i 1
(cluster mode) breaks our JSON error message:Note This gets compounded as the error stack grows larger.
Supporting information
I believe this is the same issue discussed in #3644 and #4298 and was attempted to be handled by https://github.com/keymetrics/pm2-io-apm/issues/127 / https://github.com/keymetrics/pm2-io-apm/pull/128
The problem with both fork and cluster mode is mentioned in:
Pull Request
PM2 Warning: ${error}
logExceptions
defaulttrue
for backwards compatibility ?