United4Surveillance / signal-detection-tool

A tool for detection of signals in infectious disease surveillance data.
Other
8 stars 0 forks source link

[CONCEPT] usage of renv #241

Closed tinneuro closed 7 months ago

tinneuro commented 7 months ago

Description:

Possible topic to discuss in the next tool development meeting. Do we want to use renv for us for tool development and/or do we also want to use it for the piloting countries that they install the correct package versions into an environment instead of needing to install them globally

Context:

We already started a short discussion about renv in a former PR #221 and first decided that for the piloting countries we rather just want to use the DESCRIPTION file. We decided that for this moment we would not use renv yet but should look into it in the future. The disadvantage I realised using the DESCRIPTION file and devtools::install_deps() is that

  1. it asks you to update all packages to the most recent versions available and if you deny this and have packages which are below the required versions these are not updated and you will run into problems when using the tool
  2. your packages will change for all your Rprojects but with renv they would only change for this project and be installed in a specific project library
  3. Is it an additional overhead for piloting countries to use renv or is it actually making things easier?

Objective:

Explain the primary goal or purpose of this concept.

Proposed Output:

Decision whether to use renv in general, Decision whether to use it only for development purposes or also for the piloting countries to manage required pacakges for the usage of this tool

Related Issues:

List any related issues, pull requests, or discussions that are relevant to this concept.


Background information on concepts:

Assignees should post the result of their work (the concept) in the comments section. This will then be discussed in the next call or online in the comments. When the concept has been fully documented and any necessary decisions have been made, close this issue and refer to it as a point of reference for the concept's implementation or further development.

tinneuro commented 7 months ago

This was discussed in the Tool Development Meeting on 18.05. and decided that for now also for the devlopment we will not use renv because it can create as much difficulties as it has advantages