United4Surveillance / signal-detection-tool

A tool for detection of signals in infectious disease surveillance data.
Other
8 stars 0 forks source link

trim whitespace from all character columns in input data in preprocess_data() #266

Closed tinneuro closed 6 months ago

tinneuro commented 7 months ago

Resolves #254

tinneuro commented 6 months ago

Will resolve the conflict in the NEWS.md as soon review is done.

alchalu commented 6 months ago

Hey, sorry I can't get to it today and earliest I will be able to is next wednesday. So maybe it's best to asign somebody else.

tinneuro commented 6 months ago

No worries :) Thanks for the fast feedback. Will do so.

aj-thl commented 6 months ago

Hi @tinneuro! We are able to merge this once you solve the conflicts :)

tinneuro commented 6 months ago

Thanks @aj-thl for the review! Sorry there were public holidays in germany thursday and friday. Ready to merge now :)

aj-thl commented 6 months ago

No worries! :) We also had a public holiday on Thursday here in Finland but not on Friday. I will do the merge now. Thanks again!