Add data checks for age_group column

tinneuro commented 7 months ago

Resolves #262

Additionally to what is required in #262 by trying to have enough checks on the age_group variable and feedback to the user so that the app only rarely breaks due to age_group problems afterwards and the user gets more clear feedback.

implementing a general format check of the age_group variable
checking that only one main separator is used for all age groups except first one. If more than one were used the age_groups() function would break
updating the description.md with (hopefully) clear rules how the age_group column should look like
(#262) check the last age group follows required format

tinneuro commented 6 months ago

Will resolve the conflict in the NEWS.md as soon review is done.

jaemol commented 6 months ago

Hi!

I have only noted minor things in my review - all in all, this works very well from what I can tell and test.

tinneuro commented 6 months ago

Hi :) Thanks! Minor things which you think are not worth mentioning? Not seeing anything and don't want to miss comments you made.

tinneuro commented 6 months ago

In addition I found another bug in the is_age_group_format function allowing the + to be also a seperator between the age_groups and not only used for the last age group. fixed this. Forgot to add this into the commit message

jaemol commented 6 months ago

This is great!

United4Surveillance / signal-detection-tool

Add data checks for age_group column #267