Feature/add outbreaks to results table

United4Surveillance / signal-detection-tool

A tool for detection of signals in infectious disease surveillance data.

Other

8 stars 0 forks source link

Feature/add outbreaks to results table #327

Closed aj-thl closed 1 month ago

aj-thl commented 1 month ago

Adding column "cases in outbreak" to the signal detection results table.

closes #286

tinneuro commented 1 month ago

Hi @aj-thl , thanks so much for tackling this issue! Is it fine for you if I collaborate with you on this PR? I would add some checks/transformations before in case outbreak_status does not have TRUE/FALSE values

aj-thl commented 1 month ago

Hi @tinneuro,

of course, it would be great if you could collaborate with me on this, especially as I have quite limited time available in the coming weeks. Feel free to make any changes :) Thanks for participating!

tinneuro commented 1 month ago

Ok great! Maybe you could then still review my changes?

aj-thl commented 1 month ago

Sure, let's do so.

tinneuro commented 1 month ago

Hi :) I added my changes now and am happy for a review. What I did:

added outbreak_status to the optional variables so that the data check also checks it so we are sure it is in the correct format for the sum
add tests for the aggregate_data()
added outbreak_status to the metadata information and to our example dataset
enabled level unknown to be shown when filtering (i.e. filtering for outbreak_status that unknown is also shown)

aj-thl commented 1 month ago

Hi,

Great, thank you!

I will try to review the changes that you made at the beginning of next week :)

Have a nice weekend!

tinneuro commented 1 month ago

Great thanks for testing and your review.