UnitedLexCorp / SimpleTalk

An implementation of HyperTalk in Ohm-js
Apache License 2.0
7 stars 1 forks source link

Window resize #185

Closed dkrasner closed 3 years ago

dkrasner commented 3 years ago

Main Points

This PR updates how st-window resizes. Before it was directly setting the width/height inline styles on its stack subpart, which was an early solution before we had style properties. The issue is that this prevented window state from being property serialized and from being updated/seen in the navigator (I.e. adjusting the size of the window would not be reflected in the nav).

Now window updates its width/height props.

NOTE Updating the window size and then opening the navigator throws the following error:

image

This might all be fixed with #183 or this might be due to the version of the serialization for the example files coming from #184

regardless we should be weary and potentially merge this in before #183 or rebase the latter on top of it to test.