search

UnitedLexCorp / SimpleTalk

An implementation of HyperTalk in Ohm-js
Apache License 2.0
7 stars 1 forks source link

Serialization / Drawing Fixes #189

Closed darth-cheney closed 3 years ago

darth-cheney commented 3 years ago

What

This PR implements a couple of quick fixes to issues that were breaking serialization/deserialization.

The first was that the devtool was interfering with deserialized Drawings, because the Drawing part sends messages when its image part property is set and devtool was expecting a world to already exist when intercepting all messages.

The second is that the Nav had certain expectations of lensed PartViews that was not always consistent.

Both of these have been fixed with easy changes. See the commit comments for more information.

How to Test

Try serializing anything with drawings in it and re-opening. Additionally, try importing stacks that have Drawings, like mandate.

Closes

173

177

dkrasner commented 3 years ago

@darth-cheney that looks good, merge when ready

ApproximateIdentity commented 3 years ago

Yeah things seem good here too.

dkrasner commented 3 years ago

@darth-cheney i am going to merge this (since i want to do some things which depend on drawing and seems better to branch of master)