Unity-Technologies / AssetGraph

Visual Workflow Automation Tool for Unity.
Other
1.13k stars 209 forks source link

Override setting by Platform of texture of "Overwrite Import Settings" node is not reflected. #137

Closed hiroki-o closed 6 years ago

hiroki-o commented 6 years ago

Original report by 幸道正典 (Bitbucket: 幸道正典, ).


Override setting by Platform of texture of "Overwrite Import Settings" node is not reflected.

UnityEngine.AssetGraph / Editor / System / Utility / BuildTargetUtility.cs (393) var method = objType.GetMethod ("IsBuildTargetSupported", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);

On this line, since the specification of BindingFlags.NonPublic was wrong, the reflection of Override setting by Platform was not reflected.

Correctly, it is System.Reflection.BindingFlags.Public.

Operation was confirmed with Unity 2018.1.6f1 / Windows10.


"Overwrite Import Settings"ノードのテクスチャのPlatform別Override設定が反映されない。

UnityEngine.AssetGraph/Editor/System/Utility/BuildTargetUtility.cs (393) var method = objType.GetMethod("IsBuildTargetSupported", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);

この行で、BindingFlags.NonPublicの指定が誤りのため、Platform別Override設定が反映が反映されていませんでした。

正しくは、System.Reflection.BindingFlags.Publicです。

Unity2018.1.6f1 / Windows10 で動作確認しました。

hiroki-o commented 6 years ago

Original comment by Hiroki Omae (Bitbucket: [Hiroki Omae](https://bitbucket.org/Hiroki Omae), ).


This issue is resolved with commit 7ec3d91. please give a try.