search

Unity-Technologies / BoatAttack

Demo Project using the Universal RP from Unity3D
Other
2.51k stars 946 forks source link

Add a way to get back to Main Menu from Gameplay #125

Open todi1856 opened 3 years ago

todi1856 commented 3 years ago

Ran Boat Attack on Android, there seems to be no way to get back to Main Menu from Gameplay, tried Back button, but nothing happens

PratikBorhade302 commented 3 years ago

Hi @todi1856 .I would like to work on this issue, can you suggest me the way to start it.

todi1856 commented 3 years ago

Hi @todi1856 .I would like to work on this issue, can you suggest me the way to start it.

I think somebody from Unity should fix that, I don't know if they accepts PRs from forks. Since there's nothing mentioned in the Readme

PratikBorhade302 commented 3 years ago

@todi1856 are u a project maintainer??

PratikBorhade302 commented 3 years ago

just asking If its open source then anyone can PR I guess.

todi1856 commented 3 years ago

I am not project maintainer. @Verasl can you comment?

PratikBorhade302 commented 3 years ago

ok. Not a problem. I just started with open source and eager to contribute for projects of unity.

ImanCol commented 3 years ago

ok. Not a problem. I just started with open source and eager to contribute for projects of unity.

It's off topic, but can you create a version without the use of the Input System, back to the old Unity input system? I have problems compiling with certain devices that the new Input System is not yet supported.

https://github.com/Unity-Technologies/BoatAttack/issues/128#issue-748154739

Verasl commented 3 years ago

I will be working on cleaning up the whole menu system soon, right now it is quite janky and in need of some better design to work with multiple screen types/sizes and input hardware.

It's off topic, but can you create a version without the use of the Input System, back to the old Unity input system? I have problems compiling with certain devices that the new Input System is not yet supported

I would be interested @ImanCol which platforms you had issues with the new input system? I know that the consoles(xbox one, ps4 and switch) need the additional NDA input package, if you have access to this you should be able to get this through your unity license afaik. If it is another platform other than these let me know and I will look into it here, seems weird that it doesnt work on a certain platform :(

ImanCol commented 3 years ago

I will be working on cleaning up the whole menu system soon, right now it is quite janky and in need of some better design to work with multiple screen types/sizes and input hardware.

It's off topic, but can you create a version without the use of the Input System, back to the old Unity input system? I have problems compiling with certain devices that the new Input System is not yet supported

I would be interested @ImanCol which platforms you had issues with the new input system? I know that the consoles(xbox one, ps4 and switch) need the additional NDA input package, if you have access to this you should be able to get this through your unity license afaik. If it is another platform other than these let me know and I will look into it here, seems weird that it doesnt work on a certain platform :(

Only on Nintendo Switch. I have access to the SDk, although as a beginner I find it difficult to implement the SDK Plugin to Input System. Most forums the implementation of Input System on Nintendo Switch is very scarce, so it would save me more problems if I used the old input system.

Unless of course you want to improve Input System so that the Nintendo SDK Plugin implementation is as easy as plug and play

So far I also believe that third party entry systems such as Rewired and InControl are out of date with the new entry system.

Another thing, that Input System says that it supports Switch Pro Controller lends itself to confusion knowing that it is only added to PC.

Of course it is not a problem with your game, if not with the Input System it uses. I wish you could work with the classic entry system. I would greatly appreciate it.

PratikBorhade302 commented 3 years ago

@Verasl ,so is it your own project or can I contribute?