search

Unity-Technologies / EditorXR

Author XR in XR
Other
928 stars 166 forks source link

Locomotion with new controller #454

Closed Mvivant closed 5 years ago

Mvivant commented 6 years ago

Hi,

I have an issue, I want to create a new free locomotion tools with the 3dRudder foot-controller, so I created a new device input, but here you block all other devices ("For now let's filter out any other devices other than VR controller devices; Eventually, we may support mouse / keyboard etc"), it is possible to remove this condition ?

Thanks

Mvivant commented 6 years ago

Hello,

Someone can help me or give me answer ? Please :)

amirebrahimi commented 6 years ago

Is it not possible for you to inherit from VRInputDevice?

Mvivant commented 6 years ago

No, because I want my controller to be a normal input device and not just a VR input device. (like mouse, keyboard, gamepad, etc)

mtschoen-unity commented 5 years ago

Hey there,

Unfortunately, this situation will not work with the way that we assign tools to controllers without a fair amount of re-work. I haven't tested your specific use-case, but in earlier work where we tried to support mouse input, we found that simply adding a non-VR device to an action map cause the mapping of device-to-toolstack to fail and effectively breaks that tool (it is never added to the ToolData and can never be active). It would be a non-trivial refactor to support this use case. We are no longer supporting the input prototype, but aren't yet ready to transition EXR to the new input system. As such, we don't want to allocate any more resources to improving the input system in EXR until this transition happens. At that point, we will definitely ensure support for non-VR input devices like keyboard/mouse/3dRudder.

In the meantime, are you able to support your use case in your fork of EXR? I see there is also a PR related to this issue (#464). Does that solve the issue currently, or is it just something you need to attempt your solution? Since we aren't planning to support this yet, and I don't want to introduce any regressions, I am going to close that PR.