search

Unity-Technologies / EditorXR

Author XR in XR
Other
928 stars 166 forks source link

2018 compile fixes #467

Closed stella3d closed 6 years ago

stella3d commented 6 years ago

adds a few UNITY_EDITOR defines , one i missed during the last PR and one for ComponentUtils.

adds some defines to get rid of warnings about project & hierarchy change events.

also fixes the BuildPlayer test to work in Unity 2018, using the new BuildReport object instead of a string.

mtschoen-unity commented 6 years ago

So far, the thinking has been that we just move with the Unity release cycle, and "don't look back" to supporting older versions. This would mean that we hold off on these changes until 2018.1 comes out of beta.

These changes seem to be pretty minimal, which wasn't the case moving from 5.6 -> 2017.2. I'm down to support 2017.2 going forward until it becomes impractical to do so. @AndrewTHEManeri, do you have thoughts on this?

Also, if this becomes the new policy (support all versions >= 2017.2) we should update the Readme to say that EXR requires 2017.2+

stella3d commented 6 years ago

my thinking is that the officially supported version is of course still 2017.x, but these are some very minimal changes that make it work in 2018.x for our users who use the beta (like me). just defines and a test fix.