search

Unity-Technologies / EditorXR

Author XR in XR
Other
929 stars 167 forks source link

Use assembly definition files; Get play-mode working #483

Closed AndrewTHEManeri closed 6 years ago

AndrewTHEManeri commented 6 years ago

Purpose of this PR

Enables EditorVR support in play-mode, applies assembly definition files for all submodules.

Testing status

That's what we're doing here. Let's be thorough.

Technical risk

High - the 'editor only' assumption of EXR is going away and we need to be very vigilant looking for unintended side-effects.

Comments to reviewers

Let's see what kind of velocity we have with all-eyes on everything. If we're not making much progress we might do a divide-and-conquer approach instead.

amirebrahimi commented 6 years ago

I'm happy to help with this, too. If there are a lot of changes, then one suggestion is to merge this into a local dev-branch here on this repo and then perform the PR from there. Otherwise, we'll need to make changes in the original branch.

AndrewTHEManeri commented 6 years ago

@amirebrahimi I'm getting errors about missing the SteamVR assembly and OVR Assembly. Did you make those manually or are they in updated libraries somewhere?