Unity-Technologies / EditorXR

Author XR in XR
Other
928 stars 166 forks source link

Spatial menu fixes #515

Closed dunity closed 5 years ago

dunity commented 5 years ago

Purpose of this PR

Fix the following SpatialMenu related bugs:

*Fix exceptions present in the SpatialMenuUI when first activating the SpatialMenu and attempting to scroll if the menu is not already visible

*Fix SpatialMenu not displaying when first activated in a session

*Prevent the selection of more than one menu element in the SpatialMenu when in ray-input mode

*Prevent the selection of menu elements not currently being displayed when returning to the top-level of the menu.

*Fix bug relating to the thumbstick/trackpad selection of SpatialMenu elements not allowing for selection while in ray-based input mode

*Fix rare bug in which the SpatialMenu is either empty, or only displays the "actions" category when first displayed after quickly launching the menu on session start.

Testing status

I've tested these fixes thoroughly. and saw no new issues relating to the SpatialMenu arise during testing. In testing these fixes, I've tested for actions, workspaces, and tool buttons still functioning as expected in the SpatialMenu.

Technical risk

Medium. There are some notable, but necessary changes that have been made to check for a valid button the ray might be hovering, before falling back to a button that has been selected via the thumbstick/trackpad. Manual resetting of the SpatialMenu highlight states was also added, as they weren't being reset previously, which was causing bugs.

Comments to reviewers

None