Unity-Technologies / EditorXR

Author XR in XR
Other
928 stars 166 forks source link

Misc performance improvements #522

Closed mtschoen-unity closed 5 years ago

mtschoen-unity commented 5 years ago

Purpose of this PR

Introduce minor performance optimizations

Testing status

Normal smoke test--open all workspaces and tools. This reduces about 1k of per-frame GC under normal circumstances, but a little more before the first selection is made (see below)

Technical risk

Low--All code should be functionally equivalent, but a little faster

Comments to reviewers

This was an old branch I opened last year but never got around to PR-ing

Note: includes auto-open-init-fix for convenience

What was done:

dunity commented 5 years ago

Just a heads up before review: I just pushed a merge-in of latest dev.

mtschoen-unity commented 5 years ago

the radial menu now consumes the SpatialMenu thumbstick/trackpad input

Is this an issue on development?

my first guess is the change to the MultiRayInputModule is the most likely culprit

Hm... maybe part of the SpatialMenu is registering as a valid hover target but shouldn't?

I'll see if I can reproduce the same issue.