Closed mtschoen-unity closed 5 years ago
Just a heads up before review: I just pushed a merge-in of latest dev.
the radial menu now consumes the SpatialMenu thumbstick/trackpad input
Is this an issue on development
?
my first guess is the change to the MultiRayInputModule is the most likely culprit
Hm... maybe part of the SpatialMenu is registering as a valid hover target but shouldn't?
I'll see if I can reproduce the same issue.
Purpose of this PR
Introduce minor performance optimizations
Testing status
Normal smoke test--open all workspaces and tools. This reduces about 1k of per-frame GC under normal circumstances, but a little more before the first selection is made (see below)
Technical risk
Low--All code should be functionally equivalent, but a little faster
Comments to reviewers
This was an old branch I opened last year but never got around to PR-ing
Note: includes
auto-open-init-fix
for convenienceWhat was done:
HoveringInteractable
, where a single check for all of them will do. This may pick up on some interaction types we haven't accounted for, but so far all of our UI is under our control, and there shouldn't be an issue with hovering over objects which are selectable but not clickable, for example.