Unity-Technologies / EditorXR

Author XR in XR
Other
929 stars 167 forks source link

Backwards Compatibility #547

Closed mtschoen-unity closed 5 years ago

mtschoen-unity commented 5 years ago

Purpose of this PR

Ensure that EditorXR works in older version of Unity, starting with 2017.3

Testing status

Basic smoke test passed in 2017.3.0f3, 2017.4.22f1, 2018.1.0f2, 2018.2.21f1, and 2018.3.7f1.

Technical risk

Low -- Only changes serialized files, and only replaces field names with older versions, which have working upgrade paths

Comments to reviewers

The fist-time setup in 2017.3 is a little broken because of Text Mesh Pro. The "Import TMP Essentials" step fails, but if you can get those files from elsewhere, EditorXR works fine.

I had to revert the Spatial Menu prefab back to its state before #540 because the process for going from 2018.3 to earlier versions is not as straightforward. I removed the missing script reference before converting the prefab, so it shouldn't re-introduce that issue.