Take care of a few final details for the 0.3 release
Testing status
Tested importing this branch and a package made from its contents (plus the imported asmdef patches) into 2017.4 (fails to compile), 2018.4, and 2019.2.
Technical / Halo risk
Tech Risk (not Tech Correctness, which is deferred to the reviewers)
0 could be just zero impact changes, removals but no logic changes
1 low impact, simple logic changes
2 is anything between 1 and 3
3 are extremely likely to introduce bugs
Halo Risk (Externality risk)
0 local change with no risk to other areas
1 neighbors could be affected
2 anything between 1 and 3
3 things might break everywhere]
Comments to reviewers
The first change set is simple--just wraps some unused events in #if INCLUDE_POLY_TOOLKIT so they don't create warnings if the Poly Toolkit package is not in the project.
My hope in moving VersionCheck.cs into its own file was that it would compile even if the main EXR asmdef failed to compile. Unfortunately, this is not the case. Still, I think it is cleaner to have this code in its own file. In an effort to get this to compile, I also ended up removing the reference to EXR in the Utilities/Editor assembly because it was not used.
The other modification to EditorVR.cs came up when testing the package import into 2019.2. After the multiple compiles, I found that I had to trigger a manual re-import on the EditorVR script in order for it to get a MonoImporter with the default references set. If we add this "stub" class with just he serialized references, EXR works on first import.
You should be able to see what changed in the Getting Started Guide by using Google Docs history. Broad strokes were: remove Undo Patch section, update minimum Unity version, remove steps about importing partner SDKs (🎉)
Purpose of this PR
Take care of a few final details for the 0.3 release
Testing status
Tested importing this branch and a package made from its contents (plus the imported asmdef patches) into 2017.4 (fails to compile), 2018.4, and 2019.2.
Technical / Halo risk
Tech Risk (not Tech Correctness, which is deferred to the reviewers)
1 low impact, simple logic changes
Halo Risk (Externality risk)
1 neighbors could be affected
Comments to reviewers
The first change set is simple--just wraps some unused events in #if INCLUDE_POLY_TOOLKIT so they don't create warnings if the Poly Toolkit package is not in the project.
My hope in moving
VersionCheck.csinto its own file was that it would compile even if the main EXR asmdef failed to compile. Unfortunately, this is not the case. Still, I think it is cleaner to have this code in its own file. In an effort to get this to compile, I also ended up removing the reference to EXR in the Utilities/Editor assembly because it was not used.The other modification to
EditorVR.cscame up when testing the package import into 2019.2. After the multiple compiles, I found that I had to trigger a manual re-import on the EditorVR script in order for it to get a MonoImporter with the default references set. If we add this "stub" class with just he serialized references, EXR works on first import.I've also updated
README.md, created a new copy of the Getting Started Guide, and linked to it. https://docs.google.com/document/d/1Rymrri54MeUO1UE8pev0Tss9dMAcltECOF7NAAO5XuE/editYou should be able to see what changed in the Getting Started Guide by using Google Docs history. Broad strokes were: remove Undo Patch section, update minimum Unity version, remove steps about importing partner SDKs (🎉)