Road to release: Recorder bug fixes

Unity-Technologies / GenericFrameRecorder

This GitHub package is DEPRECATED. Please get the new Unity Recorder from the Asset Store (https://assetstore.unity.com/packages/essentials/unity-recorder-94079) Use the editor builtin Bug Reporter to report issues. You can track and vote for issues on the Issue Tracker (https://issuetracker.unity3d.com)

MIT License

534 stars 66 forks source link

Road to release: Recorder bug fixes #3

Closed Adam-Myhill closed 6 years ago

Adam-Myhill commented 7 years ago

Recorder has a number of bugs which prevent it from being released just yet.

It needs further testing - this is not a complete list.

Only one openEXR method seems to work, the other renders black
Frame-range setting doesn't seem to work with multiple Timelines in scene
Single frame number render does not seem to work with multiple Timelines in scene

jasonm-unity commented 6 years ago

qa ready

jasonm-unity commented 6 years ago

implementation limitation for timeline: one frame recording will not work when that frame is at frame 0. The issue comes from the timeline sending a destroy event Before EndOfFrame event is reached, which is when the frame gets recorded.

spaceemotion commented 6 years ago

Not sure if I should open up a new issue for this, but I just noticed this: https://github.com/Unity-Technologies/GenericFrameRecorder/blob/master/source/FrameRecorder/Recorders/ImageRecorder/Engine/ImageRecorderSettings.cs#L7

The enum is called "PNGRecordeSettings" and not "PNGRecorderSettings" - that's probably a typo, right?

jasonm-unity commented 6 years ago

yup, typo. thanks for reporting that back.