FIX: Avoid cases on Android where keys can get stuck set as pressed (ISXB-475).

graham-huws commented 7 months ago

Description

Original bug reproduction - open linked project (in ISXB-475) and build for Android, connecting a physical keyboard (either bluetooth or USB) to the Android device. Hold the W key for about a second then let go. After several attempts the app will say that the W key is pressed, even though it isn't. For me (Pixel 7 Pro) this usually reproduces by the time the counter gets to about ~3000, but definitely usually happens within a few minutes.

Changes made

See comment added to the code. I don't know the area well enough to expect any negative effects, but the change certainly seems to fix the issue!

Checklist

Before review:

[x] Changelog entry added.
- Explains the change in Changed, Fixed, Added sections.
- For API change contains an example snippet and/or migration example.
- FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
- FogBugz is marked as "Resolved" with next release version correctly set.
[ ] Tests added/changed, if applicable.
- Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
- Performance tests.
- Integration tests.
[ ] Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.

During merge:

[x] Commit message for squash-merge is prefixed with one of the list:
- NEW: ___.
- FIX: ___.
- DOCS: ___.
- CHANGE: ___.
- RELEASE: 1.1.0-preview.3.

Pauliusd01 commented 6 months ago

I tried this and the testing phone I have at home does not pick up my keyboard (either via usb dock or bluetooth) Maybe @stefanunity could help QA this

stefanunity commented 6 months ago

I can't repro the issue on my Pixel 8a neither on the old unifixed Input System nor on the PR version using my MS Natural Keyboard :(

Pauliusd01 commented 6 months ago

Added area QA - @IGuscin

Pauliusd01 commented 6 months ago

Requested help from the filing CQA

Pauliusd01 commented 6 months ago

From CQA: "I tested this on 2023.2.17f1 with 1.7.0f1 input system - and it repro'd. Then I added the package from this PR and tried to repro again until the timer hit 6000 which it didn't repro even once. Checked with this device: VLNQA00267, Samsung Galaxy S10+ (SM-G975F), Android 12, CPU: Exynos 9 (9820), GPU: Mali-G76"

Unity-Technologies / InputSystem