Closed AlexTyrer closed 6 months ago
This PR addresses resource leaks in the Input Actions Editor window.
These resource leaks could lead to unexpected exceptions being thrown.
InputActionsEditorSettingsProvider is now handled by a single static instance to work around UIToolkit callback order issues identified.
Fix VisualElement handling on the StateContainer that manages the tracked serialized object representing the Input Actions.
Before review:
[x] Changelog entry added.
Changed
Fixed
Added
([case %number%](https://issuetracker.unity3d.com/issues/...))
[x] Tests added/changed, if applicable.
Area_CanDoX
Area_CanDoX_EvenIfYIsTheCase
Area_WhenIDoX_AndYHappens_ThisIsTheResult
[x] Docs for new/changed API's.
[x] Commit message for squash-merge is prefixed with one of the list:
I think this can land after QA assessment is available with approval.
Description
This PR addresses resource leaks in the Input Actions Editor window.
These resource leaks could lead to unexpected exceptions being thrown.
Changes made
InputActionsEditorSettingsProvider is now handled by a single static instance to work around UIToolkit callback order issues identified.
Fix VisualElement handling on the StateContainer that manages the tracked serialized object representing the Input Actions.
Checklist
Before review:
[x] Changelog entry added.
Changed
,Fixed
,Added
sections.([case %number%](https://issuetracker.unity3d.com/issues/...))
.[x] Tests added/changed, if applicable.
Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.[x] Docs for new/changed API's.
[x] Commit message for squash-merge is prefixed with one of the list: