Unity-Technologies / InputSystem

An efficient and versatile input system for Unity.
Other
1.43k stars 310 forks source link

Fix resource leaks in Input Actions Editor window. #1909

Closed AlexTyrer closed 6 months ago

AlexTyrer commented 6 months ago

Description

This PR addresses resource leaks in the Input Actions Editor window.

These resource leaks could lead to unexpected exceptions being thrown.

Changes made

InputActionsEditorSettingsProvider is now handled by a single static instance to work around UIToolkit callback order issues identified.

Fix VisualElement handling on the StateContainer that manages the tracked serialized object representing the Input Actions.

Checklist

Before review:

ekcoh commented 6 months ago

I think this can land after QA assessment is available with approval.