Unity-Technologies / InputSystem

An efficient and versatile input system for Unity.
Other
1.43k stars 310 forks source link

CHANGE: added more information in the dialog to restart the editor. #1913

Open smnwttbr opened 6 months ago

smnwttbr commented 6 months ago

Description

When the editor is restarted, pending import operations and windows are closed. The dialog has added information to inform the user of this. ISXB-608

Changes made

Modified dialog text.

image

Checklist

Before review:

During merge:

unity-cla-assistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

ekcoh commented 6 months ago

In addition the PR is in draft status, you should convert it into a regular PR if there are no further changes planned on it. We typically use drafts only to get some feedback when work is pending / not finished.

ekcoh commented 6 months ago

I also see you need to sign the license/CLA for CI to pass on this one. This is a one time thing you need to do to contribute to the repo.

duckets commented 5 months ago

Hi, two things: 1) I assume we've exhausted all other options that don't require this workaround, such as whether it's possible to delay showing this dialog until all importing is complete? 2) Doesn't restarting the editor automatically continue the import for anything that's not yet imported? When we say the user has to start (or restart) the import process after the editor restarts, where exactly is this button to do this?

duckets commented 4 months ago

I'm reluctant to approve this because although technically it explains to the user what to do, even with the improved text, I still think it's a bad user experience and, it's something that first-time Unity users have a high chance of encountering when importing their first demo project or starting their own first project using asset store assets. Therefore it has the potential to be one of the very first things any user experiences when starting their first project in the editor, which I think should be given significantly elevated priority as a user experience.

If it's at all possible, I think it needs looking at more closely and maybe going back to engineers for a solution that doesn't interrupt the package dependency import process.