Unity-Technologies / InputSystem

An efficient and versatile input system for Unity.
Other
1.43k stars 310 forks source link

FIX: fixed logic when checking for next composite part in the TreeView #1925

Closed smnwttbr closed 3 months ago

smnwttbr commented 5 months ago

Description

Deleting the last part of a composite action raised an exception in the editor. This PR fixes this issue. ISXB-804

Changes made

The treeview logic formerly looked for the next item to process without checking if that item exists. Changes made to address this.

Checklist

Before review:

During merge:

Pauliusd01 commented 5 months ago

Not reproing the issue anymore so would be willing to approve but I see there's discussion on the implementation so will hold off. Poke me if It's fine to pass and I'll approve

simonwittber commented 4 months ago

@ekcoh is this PR ok? IIRC we discussed accepting this PR, and scheduling other work (to add a + button to a composite) for a future time.

ekcoh commented 4 months ago

@simonwittber Sorry for the heavily delayed feedback. Let's land it as a fix for the bug.