Unity-Technologies / InputSystem

An efficient and versatile input system for Unity.
Other
1.43k stars 310 forks source link

CHANGE: Make DualSenseHIDInputReport public so it can be used in child devices #1945

Closed lewish-unity closed 3 months ago

lewish-unity commented 4 months ago

Description

Made the input report for the DualsenseHID gamepad public so that it can be used in child devices as input reports. This fixes ISXB-652 in combination with fixes in other packages.

Changes made

Checklist

Before review:

During merge:

unity-cla-assistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

Pauliusd01 commented 4 months ago

Don't see anything wrong with the changes but this does not fix ISXB-652, I still see the actual result from the bug description

image

ekcoh commented 3 months ago

@lewish-unity I noticed there is a CI failure on this one https://unity-ci.cds.internal.unity3d.com/job/38452361?utm_source=github I believe you need to update version number in package.json from "1.8.3" to "1.9.0" for API change to not generate an error.

lewish-unity commented 3 months ago

Will do, I thought this might happen with a different PR but will update it in my branch