An efficient and versatile input system for Unity.
Other
1.42k
stars
306
forks
source link
FIX: Errors are thrown when assigning Input Actions Asset that contains a custom InputProcessor or InputBindingComposite as Project-wide Input Actions (ISXB-856) #1958
The static registration of custom processor, interaction, BindingComposite could lead to undefined behavior for project action if the static initiation doesn't occur in the right order which is by design hard to control.
Changes made
Add reflection to load custom InputProcessor, IInputInteraction and InputBindingComposite during the InputManage initialisation.
Added a profiler marker for this step.
Testing
local test + bug project
Risk
It add some time in the initialisation and register all derived type which was not the case before.
We may encounter some name collision and he doesn't have a way to disable the automatic discovery.
Checklist
Before review:
[ X] Changelog entry added.
Explains the change in Changed, Fixed, Added sections.
For API change contains an example snippet and/or migration example.
JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
Description
The static registration of custom processor, interaction, BindingComposite could lead to undefined behavior for project action if the static initiation doesn't occur in the right order which is by design hard to control.
Changes made
Add reflection to load custom InputProcessor, IInputInteraction and InputBindingComposite during the InputManage initialisation. Added a profiler marker for this step.
Testing
local test + bug project
Risk
It add some time in the initialisation and register all derived type which was not the case before. We may encounter some name collision and he doesn't have a way to disable the automatic discovery.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: