Important: Always make calls to the Analytics API inside the scope of an #if ENABLE_CLOUD_SERVICES_ANALYTICS statement to prevent compilation errors on platforms that do not support Analytics:
Possible there's some things we can do to improve our UNITY_ANALYTICS defines vs ENABLE_CLOUD_SERVICES_ANALYTICS use. I raised the question on what's the difference between them. cc @ekcoh for further discussions.
For now, this will likely unblock the console platform but we should revisit this in the future IMO. Raised task here
Testing
I tested data data was sent from the macOS editor and that there apparently there's no regression in the data that is being sent. But maybe @ekcoh can validate 100% once he's back from vacation. @Pauliusd01 if you can check that there's no regression in the data sent to the backend, that would be great (I mentioning you because you approved the PR with analytics #1808 ).
Also validated that at least one console platform the build error was fixed. @lewish-unity please make sure this branch fixes the error you reported.
Risk
I validated that the Editor analytics were sent with Unity 6, but couldn't validate with 2022.3f as the analytics debugger is not available for that version.
Checklist
Before review:
[ ] Changelog entry added.
Explains the change in Changed, Fixed, Added sections.
For API change contains an example snippet and/or migration example.
JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
Description
Fix build issues on console platforms that do not support analytics.
Changes made
Guards code with
ENABLE_CLOUD_SERVICES_ANALYTICSwhich was raising compilation errors on console platforms.From documentation:
Possible there's some things we can do to improve our
UNITY_ANALYTICSdefines vsENABLE_CLOUD_SERVICES_ANALYTICSuse. I raised the question on what's the difference between them. cc @ekcoh for further discussions.For now, this will likely unblock the console platform but we should revisit this in the future IMO. Raised task here
Testing
I tested data data was sent from the macOS editor and that there apparently there's no regression in the data that is being sent. But maybe @ekcoh can validate 100% once he's back from vacation. @Pauliusd01 if you can check that there's no regression in the data sent to the backend, that would be great (I mentioning you because you approved the PR with analytics #1808 ).
Also validated that at least one console platform the build error was fixed. @lewish-unity please make sure this branch fixes the error you reported.
Risk
I validated that the Editor analytics were sent with Unity 6, but couldn't validate with 2022.3f as the analytics debugger is not available for that version.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: