Unity-Technologies / InputSystem

An efficient and versatile input system for Unity.
Other
1.43k stars 310 forks source link

CHANGE: Remove version defines for profiling. #1980

Closed surfnerd closed 2 months ago

surfnerd commented 2 months ago

Description

Remove the version defines for profiling. The changelog does not need to change since there are no functional changes here.

Changes made

The profiling.core package is not needed, just use the Unity.Profiling.ProfilerMarker from the main assembly.

Testing

Tested locally.

Risk

Low risk.

Checklist

Before review:

~~- [ ] Changelog entry added.

During merge:

After merge:

surfnerd commented 2 months ago

Thanks for this PR @surfnerd. Code changes look good to me. We just need to make sure it works fine for the Input System supported Unity range (2019 LTS and forward).

Hey @ekcoh, FYI I tested 2019.4 and Unity 6 locally.

surfnerd commented 2 months ago

based on the new Info i may need to keep the indirection. please don't merge yet

surfnerd commented 2 months ago

@ekcoh @Pauliusd01, this is good to go in terms of merging. I just wanted to do an extra check. I appreciate your patience!