search

Unity-Technologies / MeshSyncDCCPlugins

DCC plugins for MeshSync in Unity. Supported tools: Maya, Maya LT, 3ds Max, Motion Builder, Modo, Blender, Metasequoia
Other
457 stars 56 forks source link

[DONOTMERGEYET] blender-feat: Blender 3.5 support #372

Closed sindharta closed 1 year ago

sindharta commented 1 year ago

@schinkowski I rebased https://github.com/Unity-Technologies/MeshSyncDCCPlugins/pull/371 and created this PR.

However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
schinkowski commented 1 year ago

@schinkowski I rebased #371 and created this PR.

However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

I had to upgrade our cmake config to use VS 2022 to fix this.

sindharta commented 1 year ago

Ok, I'll try to setup and use VS2022. In the meantime, can you please address the existing comments ?

sindharta commented 1 year ago

@schinkowski And, have you tested that using VS2022 works for all DCC plugins that we support ?

schinkowski commented 1 year ago

@schinkowski And, have you tested that using VS2022 works for all DCC plugins that we support ?

Yes I can't see any problem with this.

seandillon92 commented 1 year ago

@schinkowski I rebased #371 and created this PR. However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

I had to upgrade our cmake config to use VS 2022 to fix this.

@schinkowski I rebased #371 and created this PR. However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

I had to upgrade our cmake config to use VS 2022 to fix this.

We should probably update our build docs for windows. Currently they mention VS 2017 as a prerequisite https://github.com/Unity-Technologies/MeshSyncDCCPlugins/blob/dev/Plugins~/Docs/en/BuildDCCPlugins.md#building-on-windows

schinkowski commented 1 year ago

Is it possible to update the documentation to make clear to users that we support Blender 3.5?

Done

sindharta commented 1 year ago

I am using VisualStudio 2022 and I still have the following errors.

First:

    54>e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125):
        error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_va
       lue_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G\U
       T\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

Second:

    54>e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126):
        error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBL
       ENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
schinkowski commented 1 year ago

@schinkowski I rebased #371 and created this PR. However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

I had to upgrade our cmake config to use VS 2022 to fix this.

@schinkowski I rebased #371 and created this PR. However, I have the following errors in both branches.

 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(117
): error C2672: 'blender::detail::make_two_value_sequence_impl': no matching overloaded function found [E:\G\UT\
MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125
): error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_
value_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G
\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]
 e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126
): error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClient
BLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

I had to upgrade our cmake config to use VS 2022 to fix this.

We should probably update our build docs for windows. Currently they mention VS 2017 as a prerequisite https://github.com/Unity-Technologies/MeshSyncDCCPlugins/blob/dev/Plugins~/Docs/en/BuildDCCPlugins.md#building-on-windows

I've updated those now

schinkowski commented 1 year ago

I am using VisualStudio 2022 and I still have the following errors.

First:

    54>e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(125):
        error C2893: Failed to specialize function template 'blender::ValueSequence<T,...> blender::detail::make_two_va
       lue_sequence_impl(blender::ValueSequence<size_t,Value1Indices...>,std::integer_sequence<size_t,Is1...>)' [E:\G\U
       T\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBLENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

Second:

    54>e:\g\ut\meshsyncdccplugins\plugins~\build\blender-3.5.0\source\blender\blenlib\BLI_parameter_pack_utils.hh(126):
        error C2065: 'is_same_v': undeclared identifier [E:\G\UT\MeshSyncDCCPlugins\Plugins~\Build\Src\MeshSyncClientBL
       ENDER_3.5.0\MeshSyncClientBlender3.5.0.vcxproj]

Did you run a clean cmake with the vs 2022 setting?