Id as string - Githubissues

Unity-Technologies / ProjectAuditor

Project Auditor is an experimental static analysis tool for Unity Projects.

Other

806 stars 66 forks source link

Id as string #101

Closed mtrive closed 2 years ago

mtrive commented 2 years ago

Problem descriptors IDs are numeric. This approach is not ideal because as it does not provide much information to the reader, IDs. In addition, it is not consistent with other diagnostics which use 2/3 letters and 4 digits.

Solution This PR changes the ID format from int to string and assign IDs based on the module they were reported from.

Code: prefix "PAC" (Project Auditor Code)
Settings: prefix "SD" (Project Auditor Setting)

note that there are different ranges within both Code and Settings diagnostic IDs:

PAC0xxx: for Unity API
PAC1xxx: for System.*
PAC2xxx: other IDs defined in code rather than in the json
PAS0xxx: Unity settings
PAS1xxx: other settings IDs defined in code rather than in the json

mtrive commented 2 years ago

I cleaned up GenericTypeInstantiationAnalyzer