Closed borisbauer-unity closed 1 year ago
I think it would be nice to see how the provider is used by modules/analyzers. Would it be possible to update this PR including k_StreamingAssetsFolderSizeLimitMb
in the settings?
I think it would be nice to see how the provider is used by modules/analyzers. Would it be possible to update this PR including
k_StreamingAssetsFolderSizeLimitMb
in the settings?
Oh, right, what I did so far is not in PA code/analyzers. And I updated only interface method calls where needed so far (the analyzers that actually use settings). For consistency I could add the provider to all modules calling their analyzers.
First, I'll add the suggested change.
Description
Added the concept of
IProjectAuditorSettingsProvider
to the ProjectAuditor, a way to stay flexible with platform specific settings provided to analyzers.Currently only one instance of the default implementation
ProjectAuditorPlatformSettingsProvider
is provided to the analyzers. It generates an editableProjectAuditorSettings
asset per platform to store the settings and keep them persistent.Changes made
ProjectAuditorPlatformSettingsProvider m_BuiltinSettingsProvider
field to ProjectAuditor to be used as a built-in and fallback providerNotes
The IProjectAuditorSettingsProvider is not used for other providers so far, only the ProjectAuditorPlatformSettingsProvider as a first functional code using settings via this interface.
TODO: Tests shall be added when we are good with the implementation. The TestFixtureBase uses the provider so it would implicitly fail if the provider is null or doesn't provide settings at all (returns a
null
setting for a given platform).Checklist
Before review:
TODO: Updating this when getting from draft to PR.
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.