Unity-Technologies / ProjectAuditor

Project Auditor is an experimental static analysis tool for Unity Projects.
Other
806 stars 66 forks source link

Feature/view sorting performance #84

Closed jacob-kjaer closed 2 years ago

jacob-kjaer commented 2 years ago

Improved sorting performance for issue views. The old method of comparison allocated tons of strings on the heap due to the way it looked up properties, the new way does the comparisons in-place and shouldn't any allocate memory at all.

Before this change, with ~135K cases, I observed up to 60s to sort on certain properties. Now all sorts are ~1s on my machine.

mtrive commented 2 years ago

Hi Jacob, thanks for taking the time to speed things up!

Apart from a few minor comments, I think there is a problem related to sorting when the UI Flat View mode is disabled. I would recommend to test it with that option disabled and try a few different views