Unity-Technologies / ProjectAuditor

Project Auditor is an experimental static analysis tool for Unity Projects.
Other
806 stars 66 forks source link

Welcome page Load button #96

Closed mtrive closed 2 years ago

mtrive commented 2 years ago

Problem it is not currently possible to load a previously saved report with running an analysis first

Solution Add the Load button to the initial "welcome" page

intro

mtrive commented 2 years ago

1 - (Optional, but consider it) move the Analyze and Load buttons in the welcome screen so that they're displayed more prominently, directly below the Modules dropdown menu.

The Welcome page will need more work to include the assemblies and config asset selections (and possibly a few other things). I'd like to revisit the Analyze/Load buttons once we have everything in place.

2 - (Optional, but consider it) Consider making the Load button load the data but not immediately go to the Summary screen. This would allow for use-cases like loading a JSON containing just code analysis, selecting Project Settings in the modules dropdown, clicking Analyze to end up on a Summary screen with both Code and Settings analysis included.

Interesting suggestion. The thing is that when loading a report, the modules selection is ignored. This is because there could be a mismatch between the available modules on the client and the ones that produced the report. Perhaps we could need a Category selection, based on the content of the report.

3 - (Not really optional). After figuring out whether to implement the suggestions above, change the screenshots and documentation at https://github.com/Unity-Technologies/ProjectAuditor/blob/master/Documentation~/GettingStarted.md accordingly to reflect the new UI and workflow.

The GettingStarted page fixed with new Analyze/Load instructions and image. Note, however, the other screenshots will also need to be updated. That will be in a separate PR though.